WIP of converting examples to Webpack v2 #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexfedoseev Can you take a look at my conversions of the webpack configs in |
alex35mil
reviewed
Mar 1, 2017
spec/dummy/client/.babelrc
Outdated
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "presets": ["es2015", "stage-0", "react"], | |||
| "presets": ["es2015", "stage-2", "react"], | |||
| "plugins": ["syntax-decorators"] | |||
There was a problem hiding this comment.
I don't think it should be here.
There was a problem hiding this comment.
you mean syntax-decorators?
There was a problem hiding this comment.
Yeah, AFAIR we don't use them anywhere.
| ), | ||
| loader: ExtractTextPlugin.extract({ | ||
| fallback: 'style-loader', | ||
| loader: [ |
| loader: [ | ||
| { | ||
| loader: 'css-loader', | ||
| query: { |
| ), | ||
| loader: ExtractTextPlugin.extract({ | ||
| fallback: 'style-loader', | ||
| loader: [ |
| loader: [ | ||
| { | ||
| loader: 'css-loader', | ||
| query: { |
|
Still some issues:
Phantomjs issue➜ ~/shakacode/react-on-rails/react_on_rails/spec/dummy (update-to-webpack-v2 u=) ✗ rspec './spec/features/integration_spec.rb[1:1:1:1]' ✹ [21:00:16]
Capybara using driver: poltergeist
Run options: include {:ids=>{"./spec/features/integration_spec.rb"=>["1:1:1:1"]}}
Hot Reload Issue➜ ~/shakacode/react-on-rails/react_on_rails/spec/dummy (update-to-webpack-v2 u=) foreman start -f Procfile.hot [21:06:20]
21:06:30 rails.1 | started with pid 7264
21:06:30 hot-assets.1 | started with pid 7265
21:06:30 rails-server-assets.1 | started with pid 7266
21:06:30 hot-assets.1 | yarn run v0.20.3
21:06:30 rails-server-assets.1 | yarn run v0.20.3
21:06:31 rails-server-assets.1 | $ (cd client && yarn run build:dev:server --silent)
21:06:31 hot-assets.1 | $ (cd client && yarn run hot-assets)
21:06:32 hot-assets.1 | yarn run v0.20.3
21:06:32 rails-server-assets.1 | yarn run v0.20.3
21:06:32 hot-assets.1 | $ babel-node server-rails-hot.js
21:06:32 rails-server-assets.1 | $ webpack -w --config webpack.server.rails.build.config.js
21:06:33 rails-server-assets.1 |
21:06:33 rails-server-assets.1 | Webpack is watching the files…
21:06:33 rails-server-assets.1 |
21:06:35 rails.1 | => Booting Puma
21:06:35 rails.1 | => Rails 4.2.8 application starting in development on http://0.0.0.0:3000
21:06:35 rails.1 | => Run `rails server -h` for more startup options
21:06:35 rails.1 | => Ctrl-C to shutdown server
21:06:35 rails.1 | ================================================================================
21:06:35 rails.1 | Using caching = false
21:06:35 rails.1 | ================================================================================
21:06:36 hot-assets.1 | /Users/justin/shakacode/react-on-rails/react_on_rails/spec/dummy/client/webpack.client.rails.hot.config.js:24
21:06:36 hot-assets.1 | config.module.loaders.push({
21:06:36 hot-assets.1 | ^
21:06:36 hot-assets.1 |
21:06:36 hot-assets.1 | TypeError: Cannot read property 'push' of undefined
21:06:36 hot-assets.1 | at Object. (/Users/justin/shakacode/react-on-rails/react_on_rails/spec/dummy/client/webpack.client.rails.hot.config.js:25:1)
21:06:36 hot-assets.1 | at Module._compile (module.js:571:32)
21:06:36 hot-assets.1 | at loader (/Users/justin/shakacode/react-on-rails/react_on_rails/spec/dummy/client/node_modules/babel-register/lib/node.js:144:5)
21:06:36 hot-assets.1 | at Object.require.extensions.(anonymous function) [as .js] (/Users/justin/shakacode/react-on-rails/react_on_rails/spec/dummy/client/node_modules/babel-register/lib/node.js:154:7)
21:06:36 hot-assets.1 | at Module.load (module.js:488:32)
21:06:36 hot-assets.1 | at tryModuleLoad (module.js:447:12)
21:06:36 hot-assets.1 | at Function.Module._load (module.js:439:3)
21:06:36 hot-assets.1 | at Module.require (module.js:498:17)
21:06:36 hot-assets.1 | at require (internal/module.js:20:19)
21:06:36 hot-assets.1 | at Object. (/Users/justin/shakacode/react-on-rails/react_on_rails/spec/dummy/client/server-rails-hot.js:20:1)
21:06:36 hot-assets.1 | error Command failed with exit code 1.
21:06:36 hot-assets.1 | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
21:06:37 hot-assets.1 | error Command failed with exit code 1.
21:06:37 hot-assets.1 | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
21:06:37 hot-assets.1 | exited with code 1
21:06:37 system | sending SIGTERM to all processes
21:06:37 rails.1 | Exiting
21:06:37 rails-server-assets.1 | terminated by SIGTERM
21:06:37 rails.1 | terminated by SIGTERM
|
|
Might be related: shakacode/react-webpack-rails-tutorial#361 |
|
|
|
Took out lots of errors! Still got 6 left. Please help! |
* Including the babel-polyfill in the registrations files. * Same for the es5shim
Require path instead of assuming it's already imported.
justin808
force-pushed
the
update-to-webpack-v2
branch
from
740e35f
to
96bed98
Compare
|
Can anybody tell me why travis is failing? https://travis-ci.org/shakacode/react_on_rails https://travis-ci.org/shakacode/react_on_rails/builds/208035037 but codeship is passing: https://app.codeship.com/projects/187011/builds/23158421 |
|
@robwise can you scan these changes. I'd like to merge soon! |
alex35mil
reviewed
Mar 6, 2017
| "jsdom": "^9.9.1", | ||
| "eslint-plugin-jsx-a11y": "^4.0.0", | ||
| "eslint-plugin-react": "^6.10.0", | ||
| "fbjs": "^0.8.9", |
There was a problem hiding this comment.
at some point, this was a peer dep...
1 similar comment
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is