Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreman dependency issue (remove foreman) #678

Merged
merged 2 commits into from
Jan 10, 2017

Conversation

x2es
Copy link
Contributor

@x2es x2es commented Jan 9, 2017

According https://github.com/ddollar/foreman

Ruby users should take care not to install foreman in their project's Gemfile.

and known issues with foreman I suggest to remove foreman from gem dependencies and install it manually.

This PR is related to discussion #675


This change is Reviewable

@coveralls
Copy link

coveralls commented Jan 9, 2017

Coverage Status

Coverage remained the same at 99.298% when pulling 5725d5a on x2es:foreman_dep_issue into 6bb07f5 on shakacode:master.

@justin808
Copy link
Member

@x2es Thanks! I'll merge this tomorrow unless I get any objections.

@justin808
Copy link
Member

Thanks @x2es

@justin808 justin808 merged commit 07e758d into shakacode:master Jan 10, 2017
justin808 pushed a commit that referenced this pull request Feb 11, 2017
* Remove foreman from dependencies and suggest to install it manually
* change `gem install foreman`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants