Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add engine doc #614

Merged
merged 1 commit into from
Nov 30, 2016
Merged

add engine doc #614

merged 1 commit into from
Nov 30, 2016

Conversation

Judahmeek
Copy link
Contributor

@Judahmeek Judahmeek commented Nov 20, 2016 •
edited by justin808
Loading

Thanks to @noahprince22! From #562 (comment)

This change is Reviewable

justin808
justin808 reviewed Nov 20, 2016
View reviewed changes
docs/additional-reading/rails-engine-integration.md
require "react_on_rails"
```
+ In your `lib/tasks/<engine_name>_tasks.rake`:
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use this syntax:

```ruby

@justin808
Copy link
Member

One comment. LGTM!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.987% when pulling 73a2b14 on Judahmeek:engine-doc into c2b85c9 on shakacode:master.

@Judahmeek
Copy link
Contributor Author

Done.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.987% when pulling 33e6464 on Judahmeek:engine-doc into c2b85c9 on shakacode:master.

@noahprince22
Copy link

Their might be an easier way to do this with config.npm_build_production_command. I'll test later and see if I can make this cleaner.

@justin808 justin808 merged commit ae9785b into shakacode:master Nov 30, 2016
@justin808
Copy link
Member

Thanks @Judahmeek!

@noahprince22 Please submit a new PR with updates!

@Judahmeek Judahmeek deleted the engine-doc branch February 24, 2017 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin808 justin808 justin808 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Judahmeek @justin808 @coveralls @noahprince22