Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Context calling React.Component constructor #612

Merged
merged 6 commits into from
Nov 20, 2016

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Nov 20, 2016

The React.Component takes one param in a call to super in the
constructor.


This change is Reviewable

The React.Component takes one param in a call to super in the
constructor.
@justin808 justin808 force-pushed the remove-unnecessary-param-basic-install branch from b275918 to 90eb7f2 Compare November 20, 2016 01:28
@justin808
Copy link
Member Author

2016-11-19_15-30-53

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.987% when pulling 4cd4f87 on remove-unnecessary-param-basic-install into 540b51e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.987% when pulling 26897f1 on remove-unnecessary-param-basic-install into 540b51e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.987% when pulling 26897f1 on remove-unnecessary-param-basic-install into 540b51e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.987% when pulling 26897f1 on remove-unnecessary-param-basic-install into 540b51e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.987% when pulling 26897f1 on remove-unnecessary-param-basic-install into 540b51e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.987% when pulling 26897f1 on remove-unnecessary-param-basic-install into 540b51e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.987% when pulling 26897f1 on remove-unnecessary-param-basic-install into 540b51e on master.

@robwise
Copy link
Contributor

robwise commented Nov 20, 2016

lgtm

@justin808 justin808 merged commit 5ada94d into master Nov 20, 2016
@robwise robwise deleted the remove-unnecessary-param-basic-install branch November 21, 2016 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants