Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #591

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Update README.md #591

merged 1 commit into from
Nov 6, 2016

Conversation

cubadomingo
Copy link
Contributor

@cubadomingo cubadomingo commented Nov 6, 2016

Fixes a small typo in the LA Ruby meetup info


This change is Reviewable

Small typo
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.987% when pulling 8bdd3d9 on cubadomingo:patch-2 into 7fecce1 on shakacode:master.

@justin808 justin808 merged commit 1ab5031 into shakacode:master Nov 6, 2016
@justin808
Copy link
Member

@cubadomingo cubadomingo deleted the patch-2 branch November 6, 2016 14:06
@cubadomingo
Copy link
Contributor Author

cubadomingo commented Nov 6, 2016

Have a couple of things I found in the article:

In the sentence "To check your machine is setup for React on Rails, git clone the React Webpack Rails Tutorial and run it!"

It seems like you're missed an if statement (see what I did there) in "To check if your machine".

Also, the sentence "From something that works, take baby steps if possible! Add one small component. Get that working.", the wording sounds a bit off to me. Maybe changing it to "Take baby steps after having working code. Add one small component. Get that working".

What I found the most helpful to me was to start off with simple React code and add the libraries afterwards; trying to jump in and add all the libraries at the beginning made things very confusing for me. This is really more of a React thing than the gem itself but I think it's great that you're referencing it. Overall I think you did a great job with this write-up. Also I watched the video tutorial and they were very helpful as well. Huge fan of all the work you're doing for the community. Keep it up Justin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants