Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure request's original_url is UTF-8 #527

Merged
merged 1 commit into from
Aug 22, 2016
Merged

Make sure request's original_url is UTF-8 #527

merged 1 commit into from
Aug 22, 2016

Conversation

lucke84
Copy link
Contributor

@lucke84 lucke84 commented Aug 21, 2016

This situation can occur in browsers that do not encode the entire URL as UTF-8,
mostly on the Windows platform (IE11 and lower). When this happens, the encoding
string is ASCII-8BIT, which generates an error if the URL contains characters
from non-latin languages.


This change is Reviewable

This situation can occur in browsers that do not encode the entire URL as UTF-8,
mostly on the Windows platform (IE11 and lower). When this happens, the encoding
string is ASCII-8BIT, which generates an error if the URL contains characters
from non-latin languages.
@justin808
Copy link
Member

Please pull in latest changes from master and CI should pass.

@lucke84
Copy link
Contributor Author

lucke84 commented Aug 22, 2016

Done it. I've squashed the branch while merging, hope it's right (cause this is becoming painful :D). BTW I don't get why my branch would fail running the testing for a change in master.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0f6f382 on FindHotel:check_encoding_of_request_original_url_to_be_utf8 into * on shakacode:master*.

@justin808
Copy link
Member

@lucke84 you should have only ONE commit here: https://github.com/shakacode/react_on_rails/pull/527/commits

git checkout check_encoding_of_request_original_url_to_be_utf8
git reset --hard bb0eb2f59df082f10d5346c6f5e5dce96d3d3fdd
git fetch
git rebase origin/master
git push -f

try that

@lucke84
Copy link
Contributor Author

lucke84 commented Aug 22, 2016

Done. Sorry for the mess with the commits, I'm still getting acquainted with rebasing properly. Thanks for the help :)

@justin808
Copy link
Member

np @lucke84

once CI passes, I'll merge and ship 6.1

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 82.609% when pulling bb0eb2f on FindHotel:check_encoding_of_request_original_url_to_be_utf8 into 8dd908a on shakacode:master.

@justin808 justin808 merged commit 5899e35 into shakacode:master Aug 22, 2016
chunming-c pushed a commit to chunming-c/react_on_rails that referenced this pull request Sep 6, 2017
chunming-c pushed a commit to chunming-c/react_on_rails that referenced this pull request Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants