-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure request's original_url is UTF-8 #527
Make sure request's original_url is UTF-8 #527
Conversation
This situation can occur in browsers that do not encode the entire URL as UTF-8, mostly on the Windows platform (IE11 and lower). When this happens, the encoding string is ASCII-8BIT, which generates an error if the URL contains characters from non-latin languages.
Please pull in latest changes from master and CI should pass. |
Done it. I've squashed the branch while merging, hope it's right (cause this is becoming painful :D). BTW I don't get why my branch would fail running the testing for a change in master. |
Changes Unknown when pulling 0f6f382 on FindHotel:check_encoding_of_request_original_url_to_be_utf8 into * on shakacode:master*. |
@lucke84 you should have only ONE commit here: https://github.com/shakacode/react_on_rails/pull/527/commits
try that |
Done. Sorry for the mess with the commits, I'm still getting acquainted with rebasing properly. Thanks for the help :) |
np @lucke84 once CI passes, I'll merge and ship 6.1 |
This situation can occur in browsers that do not encode the entire URL as UTF-8,
mostly on the Windows platform (IE11 and lower). When this happens, the encoding
string is ASCII-8BIT, which generates an error if the URL contains characters
from non-latin languages.
This change is