Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed assets symlinking for Heroku #446

Merged
merged 1 commit into from
Jun 7, 2016

Conversation

alexeuler
Copy link
Contributor

@alexeuler alexeuler commented Jun 6, 2016

The problem with Heroku was that it built the app in a tmp folder and then moved in the release folder. Symlinks were created with absolute path, so this process broke symlinks target. This fix creates relative symlinks instead.


This change is Reviewable

@justin808
Copy link
Member

Nice change to use relative symlinks.

:lgtm:

Previously, alleycat-at-git (Alexey) wrote…

Fixed assets symlinking for Heroku

The problem with Heroku was that it built the app in a tmp folder and then moved in the release folder. Symlinks were created with absolute path, so this process broke symlinks target. This fix creates relative symlinks instead.


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@alexeuler alexeuler force-pushed the hotfix/assets_heroku branch 2 times, most recently from c8d337c to 71d668e Compare June 7, 2016 06:39
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.305% when pulling 71d668e on alleycat-at-git:hotfix/assets_heroku into e462223 on shakacode:master.

@justin808
Copy link
Member

:lgtm:

Previously, coveralls wrote…

Coverage Status

Coverage remained the same at 82.305% when pulling 71d668e on alleycat-at-git:hotfix/assets_heroku into e462223 on shakacode:master.


Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.305% when pulling eb7d710 on alleycat-at-git:hotfix/assets_heroku into e462223 on shakacode:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.305% when pulling eb7d710 on alleycat-at-git:hotfix/assets_heroku into e462223 on shakacode:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.305% when pulling eb7d710 on alleycat-at-git:hotfix/assets_heroku into e462223 on shakacode:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants