Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ReactOnRails.render return a reference to the component's backing instance #234

Merged
merged 2 commits into from
Jan 28, 2016
Merged

Make ReactOnRails.render return a reference to the component's backing instance #234

merged 2 commits into from
Jan 28, 2016

Conversation

robwise
Copy link
Contributor

@robwise robwise commented Jan 27, 2016

Review on Reviewable

@robwise
Copy link
Contributor Author

robwise commented Jan 27, 2016

Finish up @DimaZab's PR: #213

@justin808
Copy link
Member

LGTM

Reviewed 4 of 5 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from the review on Reviewable.io

@justin808
Copy link
Member

@robwise This will go in 2.2.0 probably.

@justin808 justin808 added this to the 2.2 milestone Jan 27, 2016
justin808 added a commit that referenced this pull request Jan 28, 2016
@justin808
Merge pull request #234 from shakacode/return-react-element
81213f3 
Make ReactOnRails.render return a reference to the component's backing instance
@justin808 justin808 merged commit 81213f3 into master Jan 28, 2016
@justin808 justin808 deleted the return-react-element branch January 28, 2016 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@robwise @justin808 @DimaZab