Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bin dev scripts #1519

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Fix bin dev scripts #1519

merged 3 commits into from
Feb 15, 2023

Conversation

ahangarha
Copy link
Contributor

@ahangarha ahangarha commented Feb 3, 2023 •
edited by justin808
Loading

In this PR I have fixed two issues:

  • The scripts were not able to run the task runner properly.
  • The executable flag of the scripts were not preserved in the installation process.

This change is Reviewable

@justin808
Copy link
Member

LGTM. @Judahmeek please check.

@Judahmeek Judahmeek merged commit d0d45a1 into master Feb 15, 2023
@Judahmeek Judahmeek deleted the fix-bin-dev-scripts branch February 15, 2023 05:18
@ahangarha ahangarha mentioned this pull request Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Judahmeek Judahmeek Judahmeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahangarha @justin808 @Judahmeek