Don't apply babel-plugin-transform-runtime inside react-on-rails to work with babel 7 #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork with babel@7
It should be applied by user land.
Why?
The generated code depends on built babel's version.
It means that user couldn' build their code with babel@7 that depends on react-on-rails built by babel@6.
For example, babel-plugin-transform-runtime (babel 6) generates the
following code.
``` js
var _assign = require('babel-runtime/core-js/object/assign');
```
However @babel/plugin-transform-runtime (babel 7) expects the
path that beginning of `@babel/runtime/`.
The change allows to use react-on-rails on babel@7.
|
@tricknotes what about babel@6? @alexfedoseev any idea on this one? |
tricknotes
added a commit
to tricknotes/react_on_rails
that referenced
this pull request
Sep 8, 2018
…ils to work with babel@7 (shakacode#1136)" This reverts commit de06717. In general, Webpack doesn't build under `node_modules`. So react-on-rails should support browser compatible build.
justin808
pushed a commit
that referenced
this pull request
Sep 12, 2018
* Revert "Don't apply babel-plugin-transform-runtime inside react-on-rails to work with babel@7 (#1136)" This reverts commit de06717. In general, Webpack doesn't build under `node_modules`. So react-on-rails should support browser compatible build. * Specify babel-runtime as dependencies, not as peerDependencies babel-runtime is not installed Babel 7 environment. (Babel 7 denpends @babel/runtime.) So this should be depended as "dependencies".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't apply babel-plugin-transform-runtime inside react-on-rails to work with babel@7
It should be applied by user land.
Why?
The generated code depends on built babel's version.
It means that user couldn' build their code with babel@7 that depends on react-on-rails built by babel@6.
For example, babel-plugin-transform-runtime (babel 6) generates the
following code.
However @babel/plugin-transform-runtime (babel 7) expects the
path that beginning of
@babel/runtime/.The change allows to use react-on-rails on babel@7.
This change is