Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-webpack-rails-tutorial to Webpacker Lite #395

Merged
merged 5 commits into from
May 30, 2017

Conversation

justin808
Copy link
Member

@justin808 justin808 commented May 29, 2017

This change is Reviewable

@justin808 justin808 merged commit 390519b into master May 30, 2017
@justin808 justin808 deleted the react-on-rails-8-0-0-with-webpacker_lite branch May 30, 2017 07:51
@kevinhughes27
Copy link
Contributor

I had to add HOT_RELOADING=TRUE to my Procfile in addition to these changes to ensure webpacker_lite is also expecting reloading.

https://github.com/shakacode/webpacker_lite/blob/master/lib/webpacker_lite/env.rb#L14
https://github.com/shakacode/webpacker_lite/blob/master/lib/webpacker_lite/configuration.rb#L24

@justin808
Copy link
Member Author

@Judahmeek @kevinhughes27 is this something that should be added?

@kevinhughes27
Copy link
Contributor

I was initially expecting REACT_ON_RAILS_ENV=HOT to set this up for me. I think ideally we wouldn't set 2 ENV vars in the Procfile but that's just my opinion.

@justin808
Copy link
Member Author

@kevinhughes27, @Judahmeek, @conturbo, we need to finish up the half completed work of moving to React on Rails v8:

  1. Remove REACT_ON_RAILS_ENV, as that's no longer used for v8. See search
  2. Fix hot reloading in here: Possible to use React Hot Loader? #361

@kevinhughes27
Copy link
Contributor

I'm happy to PR the REACT_ON_RAILS_ENV changes to the example repo. I started implementing the changes in #361 but given the state of my project I need to continue using the old hot reloader since I can't have a root component until I finish more refactoring. I'm not sure how many others would be in that state or how much the focus of react_on_rails is for old apps vs new apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants