Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid multiple babel-polyfill loaded #29

Merged
merged 1 commit into from
Feb 8, 2016

Conversation

AllenFang
Copy link
Contributor

I think this patch will actually fix #16. Just explain again in the following

for the users who wrote webpack with es6 and there are two way to run
first is using babel-node, second is node --harmony and add require('babel/register'); at entry point. For these both condition, it will load babel/polyfill at first in runtime, so we need add a flag to avoid bootstrap-loader to load babel/polyfill again.

So I thinks this patch can fix ERROR in only one instance of babel-polyfill is allowed issue correctly.
btw, I think I can make the code more clean in the beginning of src/bootstrap.loader.js, if I have free time, I will do another PR

Thanks

Review on Reviewable

@alex35mil
Copy link
Member

Looks good, merging. Thanks, @AllenFang 👍

alex35mil added a commit that referenced this pull request Feb 8, 2016
Avoid multiple babel-polyfill loaded
@alex35mil alex35mil merged commit 614d28f into shakacode:master Feb 8, 2016
@AllenFang
Copy link
Contributor Author

@alexfedoseev, Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR in only one instance of babel-polyfill is allowed @ ./~/bootstrap-loader/loader.js 1:0-44
2 participants