Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Demo): Fix "Custom DRM System" field when set to known drm system #7843

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 8, 2025

Related to #7546

@avelad avelad added component: demo page The issue is in the demo page; does not affect production applications priority: P2 Smaller impact or easy workaround labels Jan 8, 2025
@avelad avelad added this to the v4.13 milestone Jan 8, 2025
@theodab
Copy link
Contributor

theodab commented Jan 8, 2025

Oh, though I'm not sure if the name of this PR is accurate.
It looks like this specifically fixes the case for when the "Custom DRM System" field is set to a default DRM system? As-is in that case the asset will work properly when played but won't show the drm system in the editing prompt.
If that's an accurate assessment, I'd change the name of the PR to better reflect the case that is being fixed. Something like...

chore(demo): Fix "Custom DRM System" field when set to known drm system

@avelad avelad changed the title chore(Demo): Fill "Custom DRM System" field when editing an asset chore(Demo): Fix "Custom DRM System" field when set to known drm system Jan 8, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@avelad avelad merged commit 5a62db7 into shaka-project:main Jan 8, 2025
23 checks passed
@avelad avelad deleted the demo-drm-keysystem branch January 8, 2025 12:59
avelad added a commit that referenced this pull request Jan 10, 2025
avelad added a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: demo page The issue is in the demo page; does not affect production applications priority: P2 Smaller impact or easy workaround
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants