Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): Hide ad position when the ad is non-linear #7711

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 4, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Dec 4, 2024
@avelad avelad added this to the v4.13 milestone Dec 4, 2024
@avelad avelad requested review from theodab and tykus160 December 4, 2024 10:12
ui/ad_position.js Show resolved Hide resolved
ui/ad_position.js Show resolved Hide resolved
@avelad avelad changed the title fix(UI): Hide ad position when the ad is linear fix(UI): Hide ad position when the ad is non-linear Dec 4, 2024
@avelad avelad requested a review from theodab December 4, 2024 11:19
@avelad avelad merged commit 8566836 into shaka-project:main Dec 4, 2024
17 of 18 checks passed
@avelad avelad deleted the ad-position branch December 4, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants