Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix unload call after destroy #7690

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 28, 2024

No description provided.

@avelad
Copy link
Member Author

avelad commented Nov 28, 2024

@tykus160 Discovered with #7687

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Nov 28, 2024
@avelad avelad requested review from theodab and tykus160 November 28, 2024 14:03
@avelad avelad added this to the v4.13 milestone Nov 28, 2024
@avelad avelad merged commit 18652b6 into shaka-project:main Nov 28, 2024
20 of 21 checks passed
@avelad avelad deleted the check-null branch November 28, 2024 14:25
avelad added a commit that referenced this pull request Dec 4, 2024
avelad added a commit that referenced this pull request Dec 4, 2024
joeyparrish pushed a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants