fix(UI): Fix exception while casting to mismatched player version #7631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the remote player does not have getChapters(), the proxied call returns undefined. This led to exceptions when .length was accessed. Reported as part of issue shaka-project#7546
avelad
approved these changes
Nov 19, 2024
theodab
approved these changes
Nov 19, 2024
joeyparrish
added a commit
that referenced
this pull request
Nov 19, 2024
) If the remote player does not have getChapters(), the proxied call returns undefined. This led to exceptions when .length was accessed. Reported as part of issue #7546
joeyparrish
added a commit
that referenced
this pull request
Nov 19, 2024
) If the remote player does not have getChapters(), the proxied call returns undefined. This led to exceptions when .length was accessed. Reported as part of issue #7546
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the remote player does not have getChapters(), the proxied call returns undefined. This led to exceptions when .length was accessed.
Reported as part of issue #7546