-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DASH): Live to vod transition #7404
Merged
tykus160
merged 8 commits into
shaka-project:main
from
Iragne:fix/live-to-vod-transition
Oct 15, 2024
Merged
fix(DASH): Live to vod transition #7404
tykus160
merged 8 commits into
shaka-project:main
from
Iragne:fix/live-to-vod-transition
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incremental code coverage: 100.00% |
avelad
added
type: bug
Something isn't working correctly
priority: P2
Smaller impact or easy workaround
component: DASH
The issue involves the MPEG DASH manifest format
labels
Oct 9, 2024
avelad
added
priority: P1
Big impact or workaround impractical; resolve before feature release
and removed
priority: P2
Smaller impact or easy workaround
labels
Oct 9, 2024
tykus160
reviewed
Oct 9, 2024
tykus160
approved these changes
Oct 10, 2024
@avelad @joeyparrish sorry to push for this PR but it's impacting our solution today and we would like to avoid to run a custom build. Let me know if you can review it. I'm happy to do change if needed |
avelad
pushed a commit
that referenced
this pull request
Oct 18, 2024
The PR is solving playback error in a Multi period manifest when the start time is not 0. Additionally, solving the error code 3015 due to the clear of the buffer during the playback. Fixes #7401
avelad
pushed a commit
that referenced
this pull request
Oct 18, 2024
The PR is solving playback error in a Multi period manifest when the start time is not 0. Additionally, solving the error code 3015 due to the clear of the buffer during the playback. Fixes #7401
joeyparrish
pushed a commit
that referenced
this pull request
Oct 18, 2024
The PR is solving playback error in a Multi period manifest when the start time is not 0. Additionally, solving the error code 3015 due to the clear of the buffer during the playback. Fixes #7401
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
component: DASH
The issue involves the MPEG DASH manifest format
priority: P1
Big impact or workaround impractical; resolve before feature release
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is solving playback error in a Multi period manifest when the start time is not 0.
Additionally, solving the error code 3015 due to the clear of the buffer during the playback.
Fixes #7401