Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DASH): Live to vod transition #7404

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

Iragne
Copy link
Contributor

@Iragne Iragne commented Oct 8, 2024

The PR is solving playback error in a Multi period manifest when the start time is not 0.
Additionally, solving the error code 3015 due to the clear of the buffer during the playback.
Fixes #7401

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad self-requested a review October 9, 2024 08:19
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: DASH The issue involves the MPEG DASH manifest format labels Oct 9, 2024
@avelad avelad added this to the v4.12 milestone Oct 9, 2024
@avelad avelad added priority: P1 Big impact or workaround impractical; resolve before feature release and removed priority: P2 Smaller impact or easy workaround labels Oct 9, 2024
@Iragne Iragne requested a review from tykus160 October 9, 2024 13:50
@Iragne
Copy link
Contributor Author

Iragne commented Oct 11, 2024

@avelad @joeyparrish sorry to push for this PR but it's impacting our solution today and we would like to avoid to run a custom build. Let me know if you can review it. I'm happy to do change if needed

@tykus160 tykus160 merged commit 2d14dd5 into shaka-project:main Oct 15, 2024
24 of 25 checks passed
avelad pushed a commit that referenced this pull request Oct 18, 2024
The PR is solving playback error in a Multi period manifest when the
start time is not 0.
Additionally, solving the error code 3015 due to the clear of the buffer
during the playback.
Fixes #7401
avelad pushed a commit that referenced this pull request Oct 18, 2024
The PR is solving playback error in a Multi period manifest when the
start time is not 0.
Additionally, solving the error code 3015 due to the clear of the buffer
during the playback.
Fixes #7401
joeyparrish pushed a commit that referenced this pull request Oct 18, 2024
The PR is solving playback error in a Multi period manifest when the
start time is not 0.
Additionally, solving the error code 3015 due to the clear of the buffer
during the playback.
Fixes #7401
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 14, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playback raising 3015 in a grwoing manifest
4 participants