fix: Do not disable streams on VOD #7370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 93.33% |
avelad
requested changes
Sep 25, 2024
There was a problem hiding this comment.
I think this should be explicitly enabled in case there are 404 errors for example. Sometimes 404 errors occur because someone has deleted a segment, and we want to see that the stream is not interrupted and can switch to another quality. Sometimes there is a timeout when changing networks (mobile data vs WiFi), I don't think disabling everything in VOD is a good idea.
|
See my latest comments in the issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling streams on VOD makes no sense, because they are static and they don't "recover".
This avoids an infinite loading loop (switching between streams) when VOD segments time out.
Closes #7368