-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove streaming.parsePrftBox config #7358
Conversation
Incremental code coverage: 56.90% |
feab35c
to
6c6d3ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you say we would need to have a deprecation warning for this removed config value in shaka.Player.configure
? Or was it too recent for that, I'm not sure.
Since before the event was only fired when the configuration was true (default false). And now we always fire the event. It's not a problem |
I was thinking more so that we don't create an error log for people who are currently setting the configuration value to true. It can say that the event is now fired without needing a configuration value, perhaps. |
Done! |
The site code is changed to use a parser that is always used and thus we avoid having a configuration that is not necessary.