Validate the existence of MediaSource before check MediaSource.isTypeSupported in MediaCapabilities polyfill #3225
Conversation
…Supported in MediaCapabilities polyfill
|
Hello @avelad , Thank you for catching this! |
| @@ -54,15 +54,17 @@ shaka.polyfill.MediaCapabilities = class { | |||
| // Use 'MediaSource.isTypeSupported' to check if the stream is supported. | |||
| if (mediaDecodingConfig['video']) { | |||
| const contentType = mediaDecodingConfig['video'].contentType; | |||
| const isSupported = MediaSource.isTypeSupported(contentType); | |||
| const isSupported = | |||
| window.MediaSource && MediaSource.isTypeSupported(contentType); | |||
There was a problem hiding this comment.
Ah, I see. Could this occur on iOS, since there's no MediaSource there?
Although this would fix an exception being thrown when MediaSource is not available, your solution would call all content unsupported on such a platform. Why would that be okay?
|
iOS actually supports Media Capabilities, but it doesn't support MediaSource. Since this case is rare and can only happen on some TVs, I think we can live with this, because on those TVs we would only use the src = mode. If this convinces you too, I close this PR. |
|
I can add a log for this case, and we can close the PR. Thank you! |
github-actions
bot
added
the
status: archived
Issue #1391