Extern xhr error property

[wader]

Make it possible to access the response when requests fails.

I tried to change to ['xhr'] = but then the tests failed because of type error

Hope it's correct to target v1.6.x branch.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[wader]

Related to #317

[joeyparrish]

Please read CONTRIBUTING.md and follow the instructions there.

[wader]

I signed it!

On Fri, Apr 1, 2016 at 5:01 PM, googlebot [email protected] wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify.
Thanks.

---

If you've already signed a CLA, it's possible we don't have your GitHub
username or you're using a different email address. Check your existing CLA
data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's
name.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[googlebot]

CLAs look good, thanks!

[wader]

@joeyparrish CLA signed and test added. But the test is kind of useless as currently unit tests only run on uncompiled source... i tried to run it on compiled source but then a lot of other unrelated tests fails 😞

[joeyparrish]

Yeah, you're right. The new test doesn't really help anything in this case. We could go ahead and drop it, IMO.

[wader]

@joeyparrish Ok, spec file change is gone now

[joeyparrish]

Thanks!

[wader]

@joeyparrish would it be possible to get a new 1.6.x package version to npm?

[wader]

Im looking at the 2.0 code to see how we could access the response. My guess is that in lib/net/http_plugin.js the xhr instance needs to be assign to the error somehow or?

[joeyparrish]

@wader, sure I can push a new v1.6.x release with bug fixes.

As for 2.0, I'd rather take another approach. You need the body of the HTTP response, correct? What if instead of passing up XHR, we attached the response text to error.data instead?

[joeyparrish]

v1.6.5 is up on npm now. Thanks!

[wader]

@joeyparrish Great!
Both body and status code would be nice

[joeyparrish]

@wader, v2 now includes the response body in the error object. Thanks!

[wader]

@joeyparrish Thanks! and now i see that status code was already there, nice