Always build the same input files to a stable output #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Leaning just on find for order, two different checkouts will produce different file list orders for different people building, on some OS:es / file systems.)
|
@johan, could you add appropriate entries to CONTRIBUTORS and AUTHORS as well? |
|
Certainly. |
|
Looks good, thanks! Would you be willing to make a similar pull request in our preview branch for v2? We have replaced the shell build scripts with python-based scripts. |
|
Sure; sounds worthwhile. |
|
Ah, on a closer read – don't hold your breath; my python is rusty, and I don't use the v2 branch myself for anything yet, so I probably won't take time to do that until I end up actually using/needing it there myself. |
|
Check out build/shakaBuildHelpers.py. getAllFiles() is the equivalent to v1's find commands. |
joeyparrish
added a commit
that referenced
this pull request
Mar 4, 2016
Always build the same input files to a stable output
joeyparrish
added a commit
that referenced
this pull request
Apr 8, 2016
Always build the same input files to a stable output
kfwerf
pushed a commit
to tvoli/shaka-player
that referenced
this pull request
May 12, 2016
Always build the same input files to a stable output
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaning just on
findfor order, two different checkouts will produce different file list orders for different people building it, at the moment, on some OS:es / file systems. Sorting the input file list prior to compiling makes sure that built output will produce the same result no matter who builds it where, which is all sorts of helpful when the built file is also under version control.