Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate timeToFirstByte before fire the event 'downloadheadersreceived' #7604

Closed
vlazh opened this issue Nov 15, 2024 · 0 comments · Fixed by #7605 · May be fixed by #7597
Closed

Calculate timeToFirstByte before fire the event 'downloadheadersreceived' #7604

vlazh opened this issue Nov 15, 2024 · 0 comments · Fixed by #7605 · May be fixed by #7597
Assignees
@vlazh
Labels
component: networking The issue involves the networking system of Shaka Player priority: P3 Useful but not urgent type: enhancement New feature or request
Milestone
v4.13

Comments

@vlazh
Copy link
Contributor

vlazh commented Nov 15, 2024

Is your feature request related to a problem? Please describe.

NetworkEngine calculates timeToFirstByte and store it to request object but it unavailable in 'downloadheadersreceived' event handler because it calculating before fire the event.

Describe the solution you'd like

Just move up the calculation.

Are you planning send a PR to add it?
Yes.
@vlazh vlazh added the type: enhancement New feature or request label Nov 15, 2024
@vlazh vlazh mentioned this issue Nov 15, 2024
Merged
@avelad avelad added the component: networking The issue involves the networking system of Shaka Player label Nov 15, 2024
@avelad avelad added this to the v4.13 milestone Nov 15, 2024
@avelad avelad added the priority: P3 Useful but not urgent label Nov 15, 2024
@avelad avelad closed this as completed in 0fc5316 Nov 15, 2024
@shaka-bot shaka-bot mentioned this issue Nov 15, 2024
Open
avelad pushed a commit that referenced this issue Nov 15, 2024
@vlazh @avelad
fix: Calculate timeToFirstByte before fire the event 'downloadheaders…
ceeb264 
…received' (#7605)

Fixes #7604
@shaka-bot shaka-bot mentioned this issue Nov 15, 2024
Merged
avelad pushed a commit that referenced this issue Nov 15, 2024
@vlazh @avelad
fix: Calculate timeToFirstByte before fire the event 'downloadheaders…
e7e285b 
…received' (#7605)

Fixes #7604
@shaka-bot shaka-bot mentioned this issue Nov 15, 2024
Merged
joeyparrish pushed a commit that referenced this issue Nov 19, 2024
@vlazh @joeyparrish
fix: Calculate timeToFirstByte before fire the event 'downloadheaders…
48a362e 
…received' (#7605)

Fixes #7604
@shaka-bot shaka-bot mentioned this issue Nov 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlazh vlazh

Labels
component: networking The issue involves the networking system of Shaka Player priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Milestone
v4.13
2 participants
@vlazh @avelad