fix(DASH): Fix playback after DASH period eviction #7519
Merged
+82
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
requested changes
Oct 29, 2024
joeyparrish
reviewed
Oct 30, 2024
|
Incremental code coverage: 98.08% |
ncocaign
changed the title
avelad
added
type: bug
avelad
changed the title
avelad
added
the
status: waiting on response
|
thanks for the feedback, I'm making the various modifications. |
shaka-bot
removed
the
status: waiting on response
avelad
requested changes
Nov 13, 2024
Difficult for me to add test as the issues arrive in a very specific condition (switch + segmentUpdate + period eviction in manifest update). |
…ect#7516) With this change, closeSegmentIndex() of all streams of a removed period are defered in StreamingEngine.onUpdate_() Fixes shaka-project#7516
Provide an interface between StreamEngine and ManifestParser to defer the call of closeStreamIndex durring the update of segments instead the update of the manifest. Fix eslint / jsdoc
extend shaka.extern.ManifestParser.PlayerInterface to provide the function closeSegmentIndex. SegmentIndexex are closed only if not part of an active stream.
ncocaign
force-pushed
the
fix-dash-multiperiod-freeze
branch
from
aec671a
to
697c17e
Compare
joeyparrish
changed the title
avelad
approved these changes
Nov 13, 2024
tykus160
approved these changes
Nov 13, 2024
This was referenced Nov 13, 2024
avelad
added a commit
to avelad/shaka-player
that referenced
this pull request
Nov 15, 2024
…ject#7519)" This reverts commit 5eff038.
avelad
pushed a commit
that referenced
this pull request
Nov 15, 2024
With this change, closeSegmentIndex() of all streams of a removed period are defered in StreamingEngine.onUpdate_() Fixes #7516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, closeSegmentIndex() of all streams of a removed period are defered in StreamingEngine.onUpdate_()
Fixes #7516
BEGIN_COMMIT_OVERRIDE
ignore: Reverted
END_COMMIT_OVERRIDE