Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PS4/5): Disable smooth codec switch on PS4/5 #7413

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

tykus160
Copy link
Member

Recent tests have shown that although SourceBuffer.changeType() exists on PS5, calling it when switching between AAC and EC3 always throws an exception. Disable smooth codec switch on that platform together with PS4.

@tykus160 tykus160 added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround platform: Playstation 4 Issues affecting Playstation 4 platform: Playstation 5 Issues affecting Playstation 5 labels Oct 11, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@theodab theodab merged commit 7268a2b into shaka-project:main Oct 11, 2024
22 of 23 checks passed
@avelad avelad added this to the v4.12 milestone Oct 18, 2024
avelad pushed a commit that referenced this pull request Oct 18, 2024
Recent tests have shown that although `SourceBuffer.changeType()` exists on PS5, calling it when switching between AAC and EC3 always throws an exception. Disable smooth codec switch on that platform together with PS4.
avelad pushed a commit that referenced this pull request Oct 18, 2024
Recent tests have shown that although `SourceBuffer.changeType()` exists on PS5, calling it when switching between AAC and EC3 always throws an exception. Disable smooth codec switch on that platform together with PS4.
@tykus160 tykus160 deleted the wt-codec-switch-ps5 branch October 18, 2024 12:30
joeyparrish pushed a commit that referenced this pull request Oct 18, 2024
Recent tests have shown that although `SourceBuffer.changeType()` exists on PS5, calling it when switching between AAC and EC3 always throws an exception. Disable smooth codec switch on that platform together with PS4.
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 10, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: Playstation 4 Issues affecting Playstation 4 platform: Playstation 5 Issues affecting Playstation 5 priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants