Skip to content

Commit

Permalink
fix(PS4/5): Disable smooth codec switch on PS4/5 (#7413)
Browse files Browse the repository at this point in the history
Recent tests have shown that although `SourceBuffer.changeType()` exists on PS5, calling it when switching between AAC and EC3 always throws an exception. Disable smooth codec switch on that platform together with PS4.
  • Loading branch information
tykus160 authored and avelad committed Oct 18, 2024
1 parent 0113d3c commit 6316946
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lib/util/platform.js
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ shaka.util.Platform = class {
*
* Some devices are known not to support `MediaSource.changeType`
* well. These devices should use the reload strategy. If a device
* reports that it supports `changeType` but support it reliabley
* reports that it supports `changeType` but support it unreliably
* it should be added to this list.
*
* @return {boolean}
Expand All @@ -638,7 +638,8 @@ shaka.util.Platform = class {
const Platform = shaka.util.Platform;
if (Platform.isTizen2() || Platform.isTizen3() || Platform.isTizen4() ||
Platform.isTizen5() || Platform.isTizen6() || Platform.isWebOS3() ||
Platform.isWebOS4() || Platform.isWebOS5()) {
Platform.isWebOS4() || Platform.isWebOS5() || Platform.isPS4() ||
Platform.isPS5()) {
return false;
}
// Older chromecasts without GoogleTV seem to not support SMOOTH properly.
Expand Down

0 comments on commit 6316946

Please sign in to comment.