-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segment delay is not applied after version upgrade. #7206
Comments
I see you are using 1 second duration segments, try changing the inaccurateManifestTolerance config to 0. This setting impacts your stream I think. |
I also see that your segments are 1 second, but #EXT-X-TARGETDURATION:2 says the duration is 2. |
Since we are using lowlatencyMode, inaccurateManifestTolerance is already 0. |
We use that value to calculate the delay: https://github.com/shaka-project/shaka-player/blob/main/lib/hls/hls_parser.js#L3418-L3423 |
TARGETDURATION indicates the maximum length of a segment, so even if the segment is 1 second, shouldn't TARGETDURATION be set to 2 seconds? |
If the maximum duration of your segment is 1, why do you use 2? In any case, this is the way Shaka works. |
Thank you for adding it to the 4.11 milestone. |
Can you test if this patch solves your issue? |
I think it would be more accurate because it calculates the delay based on the sum of the segment lengths. thank you! |
Have you read the FAQ and checked for duplicate open issues?
yes
If the problem is related to FairPlay, have you read the tutorial?
yes
What version of Shaka Player are you using?
4.9.5
Can you reproduce the issue with our latest release version?
yes
Can you reproduce the issue with the latest code from
main
?yes
Are you using the demo app or your own custom app?
yes
If custom app, can you reproduce the issue using our demo app?
yes
What browser and OS are you using?
window Chrome
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
https://global-media.com/live/brodi/master.m3u8
What configuration are you using? What is the output of
player.getConfiguration()
?What did you do?
I tested the first playback segment with both versions of Shaka Player.
What did you expect to happen?
Version 4.8.4 first calls and plays the third segment of the video playlist.
Version 4.9.5 initially calls and plays the first segment of the video playlist.
What actually happened?
Are you planning send a PR to fix it?
When updating from version 4.8.4 to version 4.9.5, liveSegmentsDelay is not applied.
The default value of liveSegmentsDelay is 3, which means that the 3rd segment out of 5 segments is requested and played first.
However, no matter how you set liveSegmentsDelay after the version upgrade, the first segment among the five segments is always called and played.
4.9.5 version
The text was updated successfully, but these errors were encountered: