Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to switch between Document Picture-In-Picture and Picture-In-Picture mode? #5689

Closed
Ravi-79 opened this issue Sep 27, 2023 · 7 comments · Fixed by #5690
Closed

How to switch between Document Picture-In-Picture and Picture-In-Picture mode? #5689

Ravi-79 opened this issue Sep 27, 2023 · 7 comments · Fixed by #5690
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@Ravi-79
Copy link

Ravi-79 commented Sep 27, 2023

Have you read the Tutorials?
Yes

Have you read the FAQ and checked for duplicate open issues?
I checked. There is nothing

What version of Shaka Player are you using?
v4.4.2

Please ask your question
After the latest update the browsers are using the Document Picture-In-Picture. Is there any way to switch back the old Picture-In-Picture mode?

@Ravi-79 Ravi-79 added the type: question A question from the community label Sep 27, 2023
@avelad
Copy link
Member

avelad commented Sep 27, 2023

Currently it’s not possible

@Ravi-79
Copy link
Author

Ravi-79 commented Sep 27, 2023

We are facing some accessibility issues inside the Document Picture-In-Picture window. I thought it would be better if we can switch between these options.

Having the controls inside the pip-window is very useful, but the focus-visible is not set on those controls. So, the controls are hard to access via keyboard due to the focus is not visible.

@avelad
Copy link
Member

avelad commented Sep 27, 2023

@beaufortfrancois is it possible resolve this issue?

@avelad avelad added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent and removed type: question A question from the community labels Sep 28, 2023
@avelad avelad added this to the v4.5 milestone Sep 28, 2023
@beaufortfrancois
Copy link
Contributor

Having the controls inside the pip-window is very useful, but the focus-visible is not set on those controls. So, the controls are hard to access via keyboard due to the focus is not visible.

@Ravi-79 I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=1487494 so that the Chrome team can investigate this issue. Can you share which platform you use (Windows, macOS, ChromeOS, or Linux) and a screen record maybe so that we can see the difference you experience between PiP Video and Document PiP?

@Ravi-79
Copy link
Author

Ravi-79 commented Sep 28, 2023

@Ravi-79
Copy link
Author

Ravi-79 commented Oct 10, 2023

Hi @beaufortfrancois , @avelad , is there any way of using the new document picture in picture inside an iframe?
I am getting this error
Error code: 0 object DOMException: Failed to execute 'requestWindow' on 'DocumentPictureInPicture': Opening a PiP window is only allowed from a top-level browsing context

@beaufortfrancois
Copy link
Contributor

Hi @beaufortfrancois , @avelad , is there any way of using the new document picture in picture inside an iframe? I am getting this error Error code: 0 object DOMException: Failed to execute 'requestWindow' on 'DocumentPictureInPicture': Opening a PiP window is only allowed from a top-level browsing context

None. It is not possible yet to open a PiP window from an iframe. You can follow along at WICG/document-picture-in-picture#97

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 27, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants