Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some demo app buttons must be double-clicked on iPad #2376

Closed
joeyparrish opened this issue Feb 4, 2020 · 1 comment
Closed

Some demo app buttons must be double-clicked on iPad #2376

joeyparrish opened this issue Feb 4, 2020 · 1 comment
Assignees
@theodab
Labels
component: demo page The issue is in the demo page; does not affect production applications status: archived Archived and locked; will not be updated type: external An issue with an external dependency; not our issue; sometimes kept open for tracking

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
master

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Demo app

What browser and OS are you using?
Chrome 79 (stable) & Safari 13 on iOS 13.3.1 on iPad

What are the manifest and license server URIs?
N/A

What did you do?
Touch the "dismiss" or "play" or "report bug" buttons on the demo page.

What did you expect to happen?
They should react to a click/touch, as the "home", "search", "custom content", and drawer buttons do.

What actually happened?
The button is highlighted as though hovered, but doesn't click until you touch it twice rapidly.
@joeyparrish joeyparrish added type: bug Something isn't working correctly component: demo page The issue is in the demo page; does not affect production applications labels Feb 4, 2020
@joeyparrish joeyparrish added this to the v2.6 milestone Feb 4, 2020
@theodab
Copy link
Contributor

theodab commented Feb 4, 2020

It looks like this is a problem with mdl-js-ripple-effect on iOS 13.
It's a known problem; see this issue on the MDL github. However, apparently they're no longer maintaining MDL, so they won't fix it.
Some of the people in that github issue posted possible workarounds. I'll try those out.

@theodab theodab added type: external An issue with an external dependency; not our issue; sometimes kept open for tracking and removed type: bug Something isn't working correctly labels Feb 4, 2020
@shaka-bot shaka-bot removed this from the v2.6 milestone Feb 4, 2020
joeyparrish pushed a commit that referenced this issue Mar 11, 2020
@theodab @joeyparrish
Work around MDL button bug in iOS 13.
33ee244 
In iOS 13, buttons with mdl ripple containers are broken;
seemingly, iOS 13 does not like the container having a default
opacity of 0.
This changes the default opacity to 0.01.

Fixes #2376

Change-Id: I0218d3911cce1c4b776ca6debf51ff62e4bbe4f3
@shaka-project shaka-project locked and limited conversation to collaborators Apr 4, 2020
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theodab theodab

Labels
component: demo page The issue is in the demo page; does not affect production applications status: archived Archived and locked; will not be updated type: external An issue with an external dependency; not our issue; sometimes kept open for tracking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joeyparrish @shaka-bot @theodab