Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for warning spam using http_file #951

Merged
merged 24 commits into from
Jun 22, 2021
Merged

Fix for warning spam using http_file #951

merged 24 commits into from
Jun 22, 2021

Conversation

Canta
Copy link
Contributor

@Canta Canta commented Jun 1, 2021

Details in #948

Daniel Cantarín and others added 24 commits December 31, 2019 16:14
Added ability to set by command line argument an arbitrary HLS media …
79a3d74 
…sequence number offset.
fix: wrong condition placement.
bb0a329
Changed help/doc strings as for @kqyang comments.
97950bb
Removed an unnecessary line, as stated [here](shaka-project#702 (comm…
3079acf 
…ent)).
Sent variable to constructor, as per [code review comment](shaka-proj…
83dfc23 
…ect#702 (comment)).
Several minor tweaks as for @kqyang comments:
9ad7ccc 
  * shaka-project#702 (comment)
  * shaka-project#702 (comment)
  * shaka-project#702 (comment)
Minor doc tweaks, as per review indications.
adeec48 
  * shaka-project#702 (comment)
  * shaka-project#702 (comment)
@Canta
Added missing punctuation
bbae84c
Fix for shaka-project#701.
5ca890e 
Also, added Daniel Cantarín to AUTHORS and CONTRIBUTORS files, as per @kqyang comment: shaka-project#702 (comment)
@Canta
Merge pull request #1 from google/master
ce03957 
Testing rebase using github's web UI
Sorted AUTHORS and CONTRIBUTORS files.
06547fc
Merge remote-tracking branch 'upstream/master'
38a7a75
Applying camel case to imageType attribute in TTML generation. Fixes s…
9a65e74 
…haka-project#908
Change in MPEG object type handling, as stated [here](shaka-project#9…
913876c 
…05 (comment)). Should fix shaka-project#905
@Canta
Merge pull request #3 from google/master
68f62f1 
Updating fork from master
Several changes to HttpFile implementation, as discussed in shaka-pro…
7ad4458 
…ject#939 :

   * Fixing a bug regarding "content length" and "file size" that was impeding normal HTTP operations. See issue comment 4.
   * Adding back the previously lost ability to change HTTP User Agent from command line parameter (mostly taken from termoose's code).
   * Changing the "HttpFile does not support Size()" message to VLOG(1) loglevel.
@Canta
Merge pull request #4 from google/master
b32a46a 
Merge google/master -> canta/master
Changed default HTTP UserAgent to "ShakaPackager/<version>". See shak…
1e11bfb 
…a-project#939 for details.
Changed useragent evaluation to constructor. shaka-project#939
e253261
Added http_file to atomic writes warning check. Should fix shaka-proj…
598ea70 
…ect#945
@Canta
Merge pull request #5 from google/master
6e2e094 
merging main repo
Added check for kHttpsFilePrefix when ignoring atomic write warnings. s…
a5127ac 
…haka-project#945
@Canta
Merge pull request #6 from google/master
3c808f5 
Merge google/shaka-packager into canta/shaka-packager
Fix for warning spam in file class when no "delete" method is declare…
3661dcf 
…d in subclass. shaka-project#948
@kqyang kqyang merged commit b7ef11f into shaka-project:master Jun 22, 2021
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kqyang kqyang kqyang approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Canta @kqyang