use second sample in webm and mp4 formats #835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the webm timescale calculation was also supposed to be changed, but I'm not sure how to correctly calculate it. |
kqyang
reviewed
Sep 8, 2020
| @@ -144,7 +144,8 @@ class Segmenter { | |||
| ProgressListener* progress_listener_ = nullptr; | |||
| uint64_t progress_target_ = 0u; | |||
| uint64_t accumulated_progress_ = 0u; | |||
| uint32_t sample_duration_ = 0u; | |||
| uint32_t sample_durations_[2] = {0, 0}; | |||
| uint32_t num_samples_ = 0u; | |||
| @@ -139,7 +139,8 @@ class Segmenter { | |||
| uint64_t progress_target_ = 0; | |||
| uint64_t accumulated_progress_ = 0; | |||
| uint64_t first_timestamp_ = 0; | |||
| int64_t sample_duration_ = 0; | |||
| int64_t sample_durations_[2] = {0, 0}; | |||
| int64_t num_samples_ = 0; | |||
There was a problem hiding this comment.
Should num_samples be size_t? I'm assuming only sample_durations_[2] needs to be size_t
There was a problem hiding this comment.
num_samples_ should be size type, so it should be size_t. sample_durations_ should still be int64_t.
| @@ -98,7 +98,7 @@ class Segmenter { | |||
|
|
|||
| /// @return The sample duration in the timescale of the media. | |||
| /// Returns 0 if no samples are added yet. | |||
| uint32_t sample_duration() const { return sample_duration_; } | |||
| uint32_t sample_duration() const { return sample_durations_[1]; } | |||
There was a problem hiding this comment.
Can you change uint32_t to int64_t? Same below.
| sample_durations_[num_samples_] = sample->duration(); | ||
| if (num_samples_ == 0) | ||
| first_timestamp_ = sample->pts(); | ||
| else |
|
Replaced with #838 |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as in #824 with mp2t, the second sample's duration should be stored instead of the first sample's duration for the webm and mp4 formats.