More corrections related to code review (cl_khr_fp16 for conversions K…

…hronosGroup#142)
shajder · Nov 29, 2023 · 26bac40 · 26bac40
1 parent a99d062
commit 26bac40
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/test_conformance/conversions/basic_test_conversions.cpp b/test_conformance/conversions/basic_test_conversions.cpp
@@ -550,7 +550,8 @@ void ConversionsTest::TestTypesConversion(const Type &inType,
          sat = (SaturationMode)(sat + 1))
     {
         // skip illegal saturated conversions to float type
-        if (kSaturated == sat && (outType == kfloat || outType == kdouble))
+        if (kSaturated == sat
+            && (outType == kfloat || outType == kdouble || outType == khalf))
         {
             continue;
         }

diff --git a/test_conformance/conversions/conversions_data_info.h b/test_conformance/conversions/conversions_data_info.h
@@ -72,6 +72,7 @@ struct DataInitInfo
 
 #define HFF(num) cl_half_from_float(num, DataInitInfo::halfRoundingMode)
 #define HTF(num) cl_half_to_float(num)
+#define HFD(num) cl_half_from_double(num, DataInitInfo::halfRoundingMode)
 
 struct DataInitBase : public DataInitInfo
 {
@@ -456,7 +457,7 @@ void DataInfoSpec<InType, OutType, InFP, OutFP>::conv(OutType *out, InType *in)
         if (std::is_same<cl_float, OutType>::value)
             *out = (OutType)*in;
         else if (is_out_half())
-            *out = static_cast<OutType>(HFF(*in));
+            *out = static_cast<OutType>(HFD(*in));
         else
             *out = rint(*in);
     }