[CSM] fix ingest data retry order messed up (elastic#78163)

shahzad31 · Sep 24, 2020 · 3747b34 · 3747b34
1 parent e581a75
commit 3747b34
Showing 1 changed file with 31 additions and 24 deletions.
diff --git a/x-pack/plugins/apm/e2e/ingest-data/replay.js b/x-pack/plugins/apm/e2e/ingest-data/replay.js
@@ -70,34 +70,40 @@ function incrementSpinnerCount({ success }) {
 }
 let iterIndex = 0;
 
+function setItemMetaAndHeaders(item) {
+  const headers = {
+    'content-type': 'application/x-ndjson',
+  };
+
+  if (SECRET_TOKEN) {
+    headers.Authorization = `Bearer ${SECRET_TOKEN}`;
+  }
+
+  if (item.url === '/intake/v2/rum/events') {
+    if (iterIndex === userAgents.length) {
+      // set some event agent to opbean
+      setRumAgent(item);
+      iterIndex = 0;
+    }
+    headers['User-Agent'] = userAgents[iterIndex];
+    headers['X-Forwarded-For'] = userIps[iterIndex];
+    iterIndex++;
+  }
+  return headers;
+}
+
 function setRumAgent(item) {
-  item.body = item.body.replace(
-    '"name":"client"',
-    '"name":"opbean-client-rum"'
-  );
+  if (item.body) {
+    item.body = item.body.replace(
+      '"name":"client"',
+      '"name":"opbean-client-rum"'
+    );
+  }
 }
 
-async function insertItem(item) {
+async function insertItem(item, headers) {
   try {
     const url = `${APM_SERVER_URL}${item.url}`;
-    const headers = {
-      'content-type': 'application/x-ndjson',
-    };
-
-    if (item.url === '/intake/v2/rum/events') {
-      if (iterIndex === userAgents.length) {
-        // set some event agent to opbean
-        setRumAgent(item);
-        iterIndex = 0;
-      }
-      headers['User-Agent'] = userAgents[iterIndex];
-      headers['X-Forwarded-For'] = userIps[iterIndex];
-      iterIndex++;
-    }
-
-    if (SECRET_TOKEN) {
-      headers.Authorization = `Bearer ${SECRET_TOKEN}`;
-    }
 
     await axios({
       method: item.method,
@@ -133,8 +139,9 @@ async function init() {
   await Promise.all(
     items.map(async (item) => {
       try {
+        const headers = setItemMetaAndHeaders(item);
         // retry 5 times with exponential backoff
-        await pRetry(() => limit(() => insertItem(item)), {
+        await pRetry(() => limit(() => insertItem(item, headers)), {
           retries: 5,
         });
         incrementSpinnerCount({ success: true });