Drop Not predicate util function in favor of controller-runtime `pr…

…edicate.Not`

pkg/controllerutils/predicate/predicate.go

@@ -45,24 +45,6 @@ func HasName(name string) predicate.Predicate {
 	})
 }
 
-// Not inverts the passed predicate.
-func Not(p predicate.Predicate) predicate.Predicate {
-	return predicate.Funcs{
-		CreateFunc: func(event event.CreateEvent) bool {
-			return !p.Create(event)
-		},
-		UpdateFunc: func(event event.UpdateEvent) bool {
-			return !p.Update(event)
-		},
-		GenericFunc: func(event event.GenericEvent) bool {
-			return !p.Generic(event)
-		},
-		DeleteFunc: func(event event.DeleteEvent) bool {
-			return !p.Delete(event)
-		},
-	}
-}
-
 // EventType is an alias for byte.
 type EventType byte
 

pkg/controllerutils/predicate/predicate_test.go

@@ -149,30 +149,6 @@ var _ = Describe("Predicate", func() {
 		})
 	})
 
-	Describe("#Not", func() {
-		It("should invert predicate", func() {
-			predicate := Not(predicate.Funcs{
-				CreateFunc: func(_ event.CreateEvent) bool {
-					return true
-				},
-				UpdateFunc: func(_ event.UpdateEvent) bool {
-					return true
-				},
-				GenericFunc: func(_ event.GenericEvent) bool {
-					return true
-				},
-				DeleteFunc: func(_ event.DeleteEvent) bool {
-					return true
-				},
-			})
-
-			gomega.Expect(predicate.Create(event.CreateEvent{})).To(gomega.BeFalse())
-			gomega.Expect(predicate.Update(event.UpdateEvent{})).To(gomega.BeFalse())
-			gomega.Expect(predicate.Delete(event.DeleteEvent{})).To(gomega.BeFalse())
-			gomega.Expect(predicate.Generic(event.GenericEvent{})).To(gomega.BeFalse())
-		})
-	})
-
 	DescribeTable("#ForEventTypes",
 		func(events []EventType, createMatcher, updateMatcher, deleteMatcher, genericMatcher gomegatypes.GomegaMatcher) {
 			p := ForEventTypes(events...)

pkg/scheduler/controller/shoot/add.go

@@ -42,7 +42,7 @@ func (r *Reconciler) AddToManager(mgr manager.Manager) error {
 		Named(ControllerName).
 		For(&gardencorev1beta1.Shoot{}, builder.WithPredicates(
 			r.ShootPredicate(),
-			predicateutils.Not(predicateutils.IsDeleting()),
+			predicate.Not(predicateutils.IsDeleting()),
 		)).
 		WithOptions(controller.Options{
 			MaxConcurrentReconciles: r.Config.ConcurrentSyncs,