Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSS variables to set line highlight property values #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gadenbuie
Copy link
Contributor

Hi @shafayetShafee! This is a small PR that I will improve the ergonomics for anyone wanting to customize the line highlight styles you set, without having to copy your CSS and rules into their stylesheets.

With this change, someone who wants to make the dimmed lines less opaque could add

:root {
  --lh--dim--opacity: 0.6;
  --lh--dim--opacity-hover: 0.6;
}

to their stylesheets. Then, if you ever need to adjust your CSS rules in the future, as long as you use the same CSS variables, they won't need to update their local styles.

Note: this PR shouldn't change behavior but you should definitely double check my work 😄

@shafayetShafee
Copy link
Owner

Hello @gadenbuie, Can you add some documentation regarding the CSS variables in the README?

Anyway, thanks for this PR. I feel flattered that you are contributing to this extension 😃 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants