vulkan: Enable VULKAN_HPP_NO_EXCEPTIONS broadly. #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidbus
force-pushed
the
vk-no-exceptions
branch
4 times, most recently
from
48cd589
to
1eca1f1
Compare
|
Rebased |
squidbus
force-pushed
the
vk-no-exceptions
branch
from
1eca1f1
to
c7ed6e2
Compare
squidbus
force-pushed
the
vk-no-exceptions
branch
from
c7ed6e2
to
6cb1222
Compare
diegolix29
pushed a commit
to diegolix29/shadPS4
that referenced
this pull request
Sep 25, 2024
* vulkan: Enable VULKAN_HPP_NO_EXCEPTIONS broadly. * vulkan: Use structured bindings for result where possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to some discussion in #906. Enables
VULKAN_HPP_NO_EXCEPTIONSbroadly, adjusting the necessary API calls to check the result value.In some places a non-success result will fail gracefully, where it makes sense to or other checks on the output already do so. Others I have added asserts to basically mirror the current behavior but without exceptions; these can be adjusted in the future as needed. Feel free to comment if you have any specific preferences anywhere.