Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Close Button #1421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Xphalnos
Copy link
Contributor

@Xphalnos Xphalnos commented Oct 20, 2024

I implemented the Close button because before when you press it nothing happens.

Video Demo:

close_button.mp4

@polybiusproxy
Copy link
Collaborator

I'm not sure if this should be merged. This is, at the moment, just an alternative to closing the game window, which results in a crash.
Ideally we'd want to have proper destruction of everything on the emulator, take for example, the renderer.

@Xphalnos
Copy link
Contributor Author

I'm not sure if this should be merged. This is, at the moment, just an alternative to closing the game window, which results in a crash. Ideally we'd want to have proper destruction of everything on the emulator, take for example, the renderer.

I agree but for now it's a very basic implementation of this button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants