imgui: fix End call when window is collapsed (#850)

shadps4-emu · Sep 9, 2024 · a0cf4ce · a0cf4ce
1 parent e3c2a91
commit a0cf4ce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/core/libraries/system/msgdialog_ui.cpp b/src/core/libraries/system/msgdialog_ui.cpp
@@ -253,8 +253,7 @@ void MsgDialogUi::Draw() {
     SetNextWindowCollapsed(false);
     KeepNavHighlight();
     // Hack to allow every dialog to have a unique window
-    if (Begin("Message Dialog##MessageDialog", nullptr,
-              ImGuiWindowFlags_NoDecoration | ImGuiWindowFlags_NoSavedSettings)) {
+    if (Begin("Message Dialog##MessageDialog", nullptr, ImGuiWindowFlags_NoSavedSettings)) {
         switch (state->GetMode()) {
         case MsgDialogMode::USER_MSG:
             DrawUser();
@@ -266,8 +265,8 @@ void MsgDialogUi::Draw() {
             DrawSystemMessage();
             break;
         }
-        End();
     }
+    End();
 
     first_render = false;
 }
diff --git a/src/imgui/layer/video_info.cpp b/src/imgui/layer/video_info.cpp
@@ -9,8 +9,10 @@ void ImGui::Layers::VideoInfo::Draw() {
 
     m_show = IsKeyPressed(ImGuiKey_F10, false) ^ m_show;
 
-    if (m_show && Begin("Video Info")) {
-        Text("Frame time: %.3f ms (%.1f FPS)", 1000.0f / io.Framerate, io.Framerate);
+    if (m_show) {
+        if (Begin("Video Info")) {
+            Text("Frame time: %.3f ms (%.1f FPS)", 1000.0f / io.Framerate, io.Framerate);
+        }
         End();
     }
 }