Sip008 initial support #2942
Merged
Sip008 initial support #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ghost
marked this pull request as ready for review
|
The quick test is passed,base example fie at https://github.com/shadowsocks/shadowsocks-android/blob/master/.github/doc-json.md#appendix-sample-exported-json-file 。
👍 Looks good to me, but someone else must approve. |
chenshaoju
approved these changes
Sep 19, 2020
ghost
commented
Sep 19, 2020
Stzx
approved these changes
Sep 19, 2020
database64128
approved these changes
Sep 30, 2020
- Deserialize the configuration using a constructor to set default values and initialize objects - Re-enable the UI when online config update failed
proposed by Stzx
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Compiled the code with Visual Studio
Require translation update
Require document update (readme.md, wikipage, etc)
What is the purpose of your pull request?
Description of your pull request and other information
Close #1703
Close #2939
Close #2928
Finally, here we are......
Some glitch is expected...