server: fix setTosFromConnmark typo #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Server made a connection to remote, remote replied with that connection. nf_conntrack module would not check reply-dst and reply-src by default. more information please refer to https://www.spinics.net/lists/netfilter/msg57842.html As a result, src and dst should be swapped to make nf_conntrack find the connection.
|
@babarosaM33 it's strange that after applying this commit, I found the hash value of ss-server still the same for both centos 7 and ubuntu 1804. means compiler ignored that or think it's the same? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server made a connection to remote, remote replied with that connection.
nf_conntrack module would check orig-dst and orig-src by default and find every connection that dst and src matches reply-src and reply-dst, respectively.
more information please refer to https://www.spinics.net/lists/netfilter/msg57842.html
As a result, src and dst should be swapped to make nf_conntrack find the connection.