Fix an incorrect iteration with a workList

[jkwak-work]

We cannot modify workList while iterating it, because its type List is actually an array container.

[csyonghe]

Actually it is fine to append items to a List while iterating it, and the newly appended item will be processed.

This is one major divergence from std containers, which doesn't allow this behavior. In practice we find allowing this makes a lot of code simpler (and potentially faster).

Is the code leading to any crashes or bugs? The for loop should be iterating with an integer index instead of using the iterator, if the iterator is just a pointer (and that pointer will change if the list reallocates).

[kaizhangNV]

Is the code leading to any crashes or bugs? The for loop should be iterating with an integer index instead of using the iterator, if the iterator is just a pointer (and that pointer will change if the list reallocates).

Yea, I have a same ask here

[jkwak-work]

It was causing a crash.
I will try with index as suggested.