Feature/initialize list side branch #6058

kaizhangNV · 2025-01-10T18:36:53Z

No description provided.

Add cuda-host decoration for the synthesized constructor if there is any usage of TorchTensor.

When creating invoke expression for ctor, we need to call ResolveInvoke() to find us the best candidates, however the existing lookup logic could find us the base constructor for child struct, we should eliminate this case by providing the LookupOptions::IgnoreInheritance to lookup, this requires us to create a subcontext on SemanticsVisitor to indicate that we only want to use this option on looking the constructor. This change implements this.

Apply all the initializer list logic on core moduls structs as well. Add special case handling for backwards-compatibility feature for HLSL when type cast a literal zero to a 'struct'.

Instead of checking what is C-Style struct, we should check C-Style type. Proposal is not very clear about this. Will also update proposal.

source/slang/slang-check-decl.cpp

tests/language-feature/interfaces/zero-init-interface.slang

source/slang/slang-check-overload.cpp

source/slang/hlsl.meta.slang

source/slang/slang-ast-expr.h

csyonghe · 2025-01-24T06:04:24Z

source/slang/slang-check-decl.cpp

@@ -28,6 +28,8 @@ static List<ConstructorDecl*> _getCtorList(
    SemanticsVisitor* visitor,
    StructDecl* structDecl,
    ConstructorDecl** defaultCtorOut);
+static Expr* constructDefaultInitExprForType(SemanticsVisitor* visitor, VarDeclBase* varDecl);
+void addVisibilityModifier(ASTBuilder* builder, Decl* decl, DeclVisibility vis);


We should have access to ASTBuilder directly via this?

csyonghe · 2025-01-24T06:04:50Z

source/slang/slang-check-decl.cpp

+    // We will defer the actual implementation of the constructor to the body visit, because
+    // we will have full information about each field in the struct during that stage.
+    void _synthesizeCtorSignature(StructDecl* structDecl);
+    bool _searchInitializableMembers(


naming: collectInitializableMembers

csyonghe · 2025-01-24T06:06:13Z

source/slang/slang-check-decl.cpp

@@ -331,6 +346,7 @@ struct SemanticsDeclBodyVisitor : public SemanticsDeclVisitorBase,
            StructDecl* parent,
            const bool getOnlyDefault)
        {
+            this->parent = parent;


avoid parameter names that collide with member names. can rename the parameter to inParent.

csyonghe · 2025-01-24T06:08:00Z

source/slang/slang-check-decl.cpp

@@ -2241,7 +2310,7 @@ void SemanticsDeclBodyVisitor::checkVarDeclCommon(VarDeclBase* varDecl)
    if (getOptionSet().hasOption(CompilerOptionName::ZeroInitialize) && !varDecl->initExpr &&
        as<VarDecl>(varDecl))
    {
-        varDecl->initExpr = constructDefaultInitExprForVar(this, varDecl);
+        varDecl->initExpr = constructDefaultInitExprForType(this, varDecl);


Can be done in a later PR, but we should remove zero init logic from the front-end.

csyonghe · 2025-01-24T06:26:01Z

tools/gfx/gfx.slang

@@ -1718,7 +1725,7 @@ public struct SlangDesc
 public struct ShaderCacheDesc
 {
    // The root directory for the shader cache. If not set, shader cache is disabled.
-    public NativeString shaderCachePath;
+    public NativeString shaderCachePath = {0};


I wonder why this is needed. NativeString should be treated as a default-initializable type.

NativeString has explicit constructor defined. So it's not a default-initializable type.

should provide a default ctor here.

csyonghe · 2025-01-24T06:27:15Z

tools/gfx/gfx.slang

@@ -1698,17 +1705,17 @@ public interface IDebugCallback

 public struct SlangDesc
 {
-    public NativeRef<slang::IGlobalSession> slangGlobalSession; // (optional) A slang global session object. If null will create automatically.
+    public NativeRef<slang::IGlobalSession> slangGlobalSession = {slang::IGlobalSession()}; // (optional) A slang global session object. If null will create automatically.


why do we need this change?

NativeRef also has explicit constructor defined.

We should provide a default ctor for the type.

csyonghe · 2025-01-24T06:28:10Z

tools/gfx/gfx.slang

-    public ShaderModuleSourceType sourceType;
-    public void *sourceData;
-    public Size sourceDataSize;
+    public ShaderModuleSourceType sourceType = ShaderModuleSourceType::SlangSource;


I find it weird to force initialize everything in these descs, why do we need this?

csyonghe · 2025-01-24T06:31:19Z

tests/autodiff/self-differential-type-synthesis.slang

@@ -17,7 +17,7 @@ struct Ray : IDifferentiable {
 [numthreads(1, 1, 1)]
 void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID)
 {
-    Ray ray = Ray();
+    Ray ray = Ray(0, float3(0, 0, 0), float3(0, 0, 0));


According to the spec, since float and float3 are all default-initializable types, the synthesized ctor should contain default values for these parameters, so why can't we call Ray() here?

According to our new rule,

float and float3 won't be default-initializable types anymore, because they all have explicit ctor defined.
If we want to make them default-initializable type, we have to define default ctor for them.

I think this may require the same treatment as C-style types, in that the explicit ctor rule applies to user defined types, but for builtin vectors, scalars, matrices we still want to treat them as default initializable.

I am not sure about the consequences yet, so maybe we do this as a follow up.

Yes, I recommend we should keep this as it, every time when we change the proposal, it could potential break things.

source/slang/slang-check-decl.cpp

source/slang/slang-ast-decl.h

source/slang/slang-check-decl.cpp

csyonghe · 2025-01-24T06:43:51Z

source/slang/slang-check-decl.cpp

+    memberExpr->scope = scope;
+    memberExpr->loc = member->loc;
+    memberExpr->name = member->getName();
+    memberExpr->type = DeclRefType::create(getASTBuilder(), member->getDefaultDeclRef());


member->getDefaultDeclRef() is a declref to the member and not to a type, it can't be used in DeclRefType::create() IIRC.

The declref you pass to DeclRefType::create() can only refer to a struct, enum, typedef or interface.

source/slang/slang-check-decl.cpp

source/slang/slang-check-expr.cpp

source/slang/slang-check-overload.cpp

kaizhangNV requested review from tangent-vector, csyonghe, expipiplus1 and a team as code owners January 10, 2025 18:36

kaizhangNV marked this pull request as draft January 10, 2025 18:37

kaizhangNV added the pr: breaking change PRs with breaking changes label Jan 10, 2025

kaizhangNV removed request for a team, expipiplus1, csyonghe and tangent-vector January 10, 2025 18:37

kaizhangNV force-pushed the feature/initialize-list-side-branch branch 12 times, most recently from 282ad96 to 8be343e Compare January 16, 2025 04:51

kaizhangNV mentioned this pull request Jan 16, 2025

re-implement zero-initialize option #6109

Open

kaizhangNV force-pushed the feature/initialize-list-side-branch branch 6 times, most recently from 2f3c992 to 7c5a8e8 Compare January 17, 2025 05:16

kaizhangNV marked this pull request as ready for review January 17, 2025 16:57

kaizhangNV added 9 commits January 23, 2025 09:06

remove hlsl-syntax.slang.expected files

18d5cfe

remove unnecessary lines

aa53f84

Add cuda-host decoration for the synthesized constructor

5653d3b

Add cuda-host decoration for the synthesized constructor if there is any usage of TorchTensor.

Address low hanging fruit comments and format

51a938e

Remove the restriction on the structs in core module

bc9cf13

Apply all the initializer list logic on core moduls structs as well. Add special case handling for backwards-compatibility feature for HLSL when type cast a literal zero to a 'struct'.

fix test break because of core module change

01b65c8

Rework on the CStyle type check

d508623

Instead of checking what is C-Style struct, we should check C-Style type. Proposal is not very clear about this. Will also update proposal.

revert a test change

c5b43c5

kaizhangNV force-pushed the feature/initialize-list-side-branch branch 5 times, most recently from 1788d3b to 55ea908 Compare January 24, 2025 01:20

csyonghe reviewed Jan 24, 2025

View reviewed changes

source/slang/slang-check-decl.cpp Outdated Show resolved Hide resolved

Remove the code removing invalid member init ctor

9194117

kaizhangNV force-pushed the feature/initialize-list-side-branch branch from 55ea908 to 9194117 Compare January 24, 2025 01:30

csyonghe reviewed Jan 24, 2025

View reviewed changes

tests/language-feature/interfaces/zero-init-interface.slang Outdated Show resolved Hide resolved

source/slang/slang-check-overload.cpp Outdated Show resolved Hide resolved

source/slang/hlsl.meta.slang Show resolved Hide resolved

kaizhangNV added 4 commits January 23, 2025 17:45

Missing check c-style type for element of sized array

f5493b4

Fix test diagnose issue

d7722af

refactor parameter name

f690690

Remove the flag indicating ctor defined in extension

2e40374

csyonghe reviewed Jan 24, 2025

View reviewed changes

kaizhangNV added 5 commits January 24, 2025 08:56

DNI: remove flag to indicate synthesied ctor check

f5b01cc

rename m_synthesizedForTypeCastZero to useCStyleInitialization

c673281

Avoid coerce logic when synthesize ctor invoke call

7b352e1

fix smoke-gfx test

63f7a56

remove m_synthesizedCtorMap as we won't synthesized ctors

6c7cdf7

csyonghe mentioned this pull request Jan 25, 2025

Coercing Initializer List to Tuple leads to invalid SPIRV. #6159

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/initialize list side branch #6058

Feature/initialize list side branch #6058

kaizhangNV commented Jan 10, 2025

csyonghe Jan 24, 2025

csyonghe Jan 24, 2025

csyonghe Jan 24, 2025

csyonghe Jan 24, 2025

csyonghe Jan 24, 2025

kaizhangNV Jan 24, 2025

csyonghe Jan 24, 2025

csyonghe Jan 24, 2025

kaizhangNV Jan 24, 2025

csyonghe Jan 24, 2025

csyonghe Jan 24, 2025

csyonghe Jan 24, 2025

kaizhangNV Jan 24, 2025

csyonghe Jan 24, 2025

kaizhangNV Jan 24, 2025

csyonghe Jan 24, 2025

Feature/initialize list side branch #6058

Are you sure you want to change the base?

Feature/initialize list side branch #6058

Conversation

kaizhangNV commented Jan 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment