Fix markNonContextParamsAsSideEffectFree.
#6054
Open
+174
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
force-pushed
the
autodiff-fix
branch
from
f3d9a36 to
a6a63d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
markNonContextParamsAsSideEffectFreeis supposed to mark all parameters except the intermediate context parameter asIgnoreSideEffect. However, the function is not implemented correctly. It checks if a parameter is an intermediate context by checking if its type isIRIntermediateContextType. However at the time this function is called, the intermediate context type is already lowered into astruct, so the current implementation will always mark all parameters asIngoreSideEffect. which result in the compiler to aggressively remove/ignore many primal function calls during autodiff pass when it shouldn't.This PR fixes this bug by explicitly marking the intermediate context parameter with a
PrimalContextdecoration, and instead of checking parameter types inmarkNonContextParamsAsSideEffectFree, we simply look for this decoration to test if a parameter is an intermediate context.Closes #6039.
Closes #6041.
Closes #6048.