Emit errors when seeing a matrix with row/col count of 1 #6044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such matrices aren't well supported by our targets, and we currently don't transform such types to supported ones. Therefore, generate an error rather than outputting invalid target code. This closes shader-slang#5987.
aleino-nv
commented
Jan 9, 2025
| @@ -11876,6 +11876,20 @@ void SemanticsDeclAttributesVisitor::checkVarDeclCommon(VarDeclBase* varDecl) | |||
| getSink()->diagnose(varDecl, Diagnostics::pushOrSpecializationConstantCannotBeStatic); | |||
| } | |||
| } | |||
|
|
|||
| if (auto matrixType = as<MatrixExpressionType>(varDecl->getType())) | |||
There was a problem hiding this comment.
I found out that this is not quite the right place for this check.
There was a problem hiding this comment.
Given that we eventually still plan to implement the support, I am fine with just add a last minute error reporting from the backend before emitting target code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such matrices aren't well supported by our targets, and we currently don't transform such types to supported ones.
Therefore, generate an error rather than outputting invalid target code.
This closes #5987.