Add backtraces to examples #5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
added a commit
to aleino-nv/slang
that referenced
this pull request
Dec 31, 2024
…trace Format code for PR shader-slang#5973
aleino-nv
commented
Jan 2, 2025
aleino-nv
force-pushed
the
aleino/examples-backtrace
branch
2 times, most recently
from
61e8ed6 to
5d202bd
Compare
expipiplus1
requested changes
Jan 2, 2025
| return true; | ||
| } | ||
|
|
||
| // NOTE: This function is not thread-safe, due to usage of StackWalk64 and static buffers. |
There was a problem hiding this comment.
We should use a mutex here to make this function reentrant
There was a problem hiding this comment.
It's currently only called from the main thread.
I suppose it's possible some other thread will call these dbghelp API's, is that the concern?
If so I would prefer it if the function was "externally synchronized" i.e. the mutex is around the call site.
aleino-nv
commented
Jan 2, 2025
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
force-pushed
the
aleino/examples-backtrace
branch
from
5d202bd to
1bfebf9
Compare
aleino-nv
commented
Jan 3, 2025
aleino-nv
force-pushed
the
aleino/examples-backtrace
branch
from
1bfebf9 to
664740c
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
added a commit
to aleino-nv/slang
that referenced
this pull request
Jan 3, 2025
…trace Format code for PR shader-slang#5973
For now, this is only implemented on Windows. This helps to address shader-slang#5520.
aleino-nv
force-pushed
the
aleino/examples-backtrace
branch
from
c8bfbb4 to
3abb2c6
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
…trace Format code for PR shader-slang#5973
csyonghe
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainandWinMainexamples.WinMainexample programs, redirect stdout tostdout-[example].txtand print that in CI if it's found.This helps to address #5520.