Fix issue with slang-embed & include ordering #5680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheneym2
approved these changes
Nov 26, 2024
| @@ -91,7 +98,7 @@ struct App | |||
|
|
|||
| if (!inputPath || (argc != 0)) | |||
| { | |||
| fprintf(stderr, "usage: %s inputPath [outputPath]\n", appName); | |||
| fprintf(stderr, "usage: %s inputPath includeDir [outputPath]\n", appName); | |||
There was a problem hiding this comment.
If includeDir is required, maybe add "|| !includeDir" to the condition above, otherwise if includeDir is optional, it should be shown in brackets here.
There was a problem hiding this comment.
Uh-oh, I think auto-merge merged it in before I could react to the comment..
Let me open another PR for the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: shader-slang/slang-torch#23
Our slang-torch repository keeps breaking due to relative paths being occasionally re-written (e.g.
#include "slang.h"vs.#include "../../include/slang.h"), exacerbated by the fact that we don't have slang-torch on CI yet.This PR adds an include directory to the slang-embed tool to avoid this issue in the future.