Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] fix spirv dead links on toc.html #5638

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

burak-efe
Copy link
Contributor

I believe this will fix the dead links that occurred because of sub section renames.

I believe this will fix the dead links that occurred because of sub section renames.
@burak-efe burak-efe requested a review from a team as a code owner November 22, 2024 07:10
@csyonghe
Copy link
Collaborator

Thank you for spotting and fixing this issue!

the toc.html is generated by running build_toc.ps1 in docs/. Is this produced by the script?

@burak-efe
Copy link
Contributor Author

burak-efe commented Nov 22, 2024

Thank you for spotting and fixing this issue!

the toc.html is generated by running build_toc.ps1 in docs/. Is this produced by the script?

oh, no. I just copy pasted section names. I guess you can consider this just as a issue rather than pr, if its not gonna solve the issue

Copy link
Collaborator

@csyonghe csyonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to merge this in assuming the script generated toc.html will be identical. If this breaks again, we should consider it an issue.

@csyonghe csyonghe merged commit a2626ea into shader-slang:master Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants