Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Matrix overload for exp10() core lib function #5620

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Add Matrix overload for exp10() core lib function #5620

merged 1 commit into from
Nov 20, 2024

Conversation

bprb
Copy link
Contributor

@bprb bprb commented Nov 20, 2024

Fixes #5579

@bprb bprb requested a review from a team as a code owner November 20, 2024 21:14
@bprb
Copy link
Contributor Author

bprb commented Nov 20, 2024

Note I didn't manually verify the numbers, I just assume exp10 "happened" and copy pasted actual into expected.

csyonghe
csyonghe approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@csyonghe csyonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for your contribution!

@csyonghe csyonghe added the pr: non-breaking PRs without breaking changes label Nov 20, 2024
@csyonghe csyonghe merged commit 4f6b928 into shader-slang:master Nov 20, 2024
14 of 15 checks passed
@bprb bprb deleted the bpe_5579_exp10_matrix branch November 21, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csyonghe csyonghe csyonghe approved these changes

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Matrix overload for exp10() core lib function
2 participants
@bprb @csyonghe