Document WGSL specific features #5571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
reviewed
Nov 15, 2024
aleino-nv
force-pushed
the
aleino/wgpu
branch
from
88cbc7b to
3956403
Compare
csyonghe
reviewed
Nov 18, 2024
aleino-nv
force-pushed
the
aleino/wgpu
branch
from
3956403 to
9814804
Compare
csyonghe
approved these changes
Nov 19, 2024
jkwak-work
reviewed
Nov 19, 2024
Comment on lines
+55
to
+58
| Supported HLSL features when targeting WGSL | ||
| ------------------------------------------- | ||
|
|
||
| The following table lists Slang's support for various HLSL feature sets, when targeting WGSL. |
There was a problem hiding this comment.
The mention of HLSL doesn't seem appropriate.
Maybe we can say it without using the word HLSL
Supported features when targeting WGSL
Or we can replace it with Slang
Supported Slang features when targeting WGSL
There was a problem hiding this comment.
IMO, deferring to HLSL is useful if someone wants to read more about any given feature.
We haven't documented each of these feature sets ourselves, as far as I know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some initial documentation of how WGSL is targeted by Slang.
Issue #5567