Embed core module in wasm build. #5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
reviewed
Nov 15, 2024
| "UInt", | ||
| "Index", | ||
| "Count", | ||
| "UIndex", |
There was a problem hiding this comment.
How will this code get updated if the names these types change?
There was a problem hiding this comment.
There is not a good way to guard against that unfortunately. But we shouldn't be changing the names of these types.
aleino-nv
reviewed
Nov 15, 2024
tools/slang-cpp-extractor/parser.cpp
Outdated
| "UIndex", | ||
| "UCount", | ||
| "PtrInt", | ||
| "intptr_t"}; |
There was a problem hiding this comment.
There is also uintptr_t
Format code for PR shader-slang#5569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to embed prebuilt core module in WebAssembly.
The main issue being fixed here is that some of our AST nodes contain fields of type
IndexorUInt, whose sizes are architecture dependent. This means that the serialized module produced from x64 build system won't correct load by the web assembly module, which is 32-bit. The fix is to get rid of these arch-dependent int types in AST nodes.To prevent future regression, the slang-cpp-extract application is updated to report an error if it sees an AST node field is of such types.